generate JetStream models with NJsonSchema #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Caleb Lloyd <[email protected]>
mtmk
added a commit
that referenced
this pull request
Jul 13, 2023
* Started JetStream project * Test projects tidy-up and minor fixes * Seperated JetStream tests * Naming fix for JS * Exclude JetStream from NuGet for now * Adding generated records (#88) * Adding records to jumpstart jetstream * by hand changes * Fixed stream model names * Set minimum stream config defaults * Fixed JSON types * better conversion (#89) * Increased logging on flaky test * generate JetStream models with NJsonSchema (#90) Signed-off-by: Caleb Lloyd <[email protected]> * Trace another flaky test --------- Signed-off-by: Caleb Lloyd <[email protected]> Co-authored-by: Scott Fauerbach <[email protected]> Co-authored-by: Caleb Lloyd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses NJsonSchema and schemas from jsm.go to generate JetStream models.
I copied the schema files to this project, as I did end up editing them slightly. We may just want to treat this as a 1-time import though, where the models can be hand edited afterwards and don't need to stay in sync. f that is the case, I can remove the schema files and import script from the PR. Or we can leave them for now, and remove them in the future once they have diverged.